----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/#review147762 -----------------------------------------------------------
src/slave/http.cpp (line 1869) <https://reviews.apache.org/r/51625/#comment215001> I think you need `(size_t) getContainers.containers_size()` here. It complains on OSX - Jay Guo On Sept. 5, 2016, 9:46 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51625/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2016, 9:46 a.m.) > > > Review request for mesos, Anand Mazumdar, Jay Guo, Vinod Kone, and Zhitao Li. > > > Bugs: MESOS-6124 > https://issues.apache.org/jira/browse/MESOS-6124 > > > Repository: mesos > > > Description > ------- > > Add a `_getContainers` method to return the containers information in > Operator API v1 protobuf format and switch `getContainers` to use it > directly. Then it would be more easier to show the containers > information in the response of `getState` by reuse `_getContainers`. > > > Diffs > ----- > > src/slave/http.cpp 2cbf3c57e294f0d47d64915371b4a6bbf9cdfc0a > src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 > > Diff: https://reviews.apache.org/r/51625/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*AgentAPITest.GetContainers*" --verbose > [ OK ] ContentType/AgentAPITest.GetContainers/1 (85 ms) > [----------] 2 tests from ContentType/AgentAPITest (263 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (284 ms total) > [ PASSED ] 2 tests. > ``` > > > Thanks, > > haosdent huang > >
