-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51625/
-----------------------------------------------------------
(Updated Sept. 12, 2016, 4:50 p.m.)
Review request for mesos, Anand Mazumdar, Jay Guo, Vinod Kone, and Zhitao Li.
Changes
-------
Address @vinodkone and @guoger's comments.
Bugs: MESOS-6124
https://issues.apache.org/jira/browse/MESOS-6124
Repository: mesos
Description (updated)
-------
Add a `_getContainers` method to return the containers information in
Operator API v1 protobuf format and switch `getContainers` to use it
directly. Then it would be easier to show the containers
information in the response of `getState` by reusing `_getContainers`.
Additionally, add supporting to filter containers by `principal` as
well.
Diffs (updated)
-----
src/internal/evolve.cpp 9ae720cdc22c6bcdd56bc6bb391419c52df446f3
src/slave/http.cpp 2cbf3c57e294f0d47d64915371b4a6bbf9cdfc0a
src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6
Diff: https://reviews.apache.org/r/51625/diff/
Testing
-------
```
sudo GLOG_v=1 ./bin/mesos-tests.sh
--gtest_filter="*AgentAPITest.GetContainers*" --verbose
[ OK ] ContentType/AgentAPITest.GetContainers/1 (85 ms)
[----------] 2 tests from ContentType/AgentAPITest (263 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (284 ms total)
[ PASSED ] 2 tests.
```
Thanks,
haosdent huang
