----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51653/#review147842 -----------------------------------------------------------
Bad patch! Reviews applied: [51653, 51021, 51377, 51376, 51375, 51374, 51371, 51020, 50846, 50845, 50844, 50707, 50706, 50705, 50704, 50703, 50702, 50701, 50700, 50699, 50422, 50418, 50417, 50416, 50235] Failed command: ./support/apply-review.sh -n -r 50845 Error: 2016-09-06 15:05:10 URL:https://reviews.apache.org/r/50845/diff/raw/ [23446/23446] -> "50845.patch" [1] error: patch failed: src/master/master.cpp:5653 error: src/master/master.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15132/console - Mesos ReviewBot On Sept. 6, 2016, 1:51 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51653/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 1:51 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5965 > https://issues.apache.org/jira/browse/MESOS-5965 > > > Repository: mesos > > > Description > ------- > > Now that we wait for the agent to be removed from the registry before > stopping the SlaveObserver, it is possible for an agent to fail health > checks multiple times if the registry operation takes longer than > `agent_ping_timeout`. > > This commit updates the master logic to handle this by ignoring health > check failures while the registry operation to mark the agent > unreachable is still in progress. > > > Diffs > ----- > > src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > > Diff: https://reviews.apache.org/r/51653/diff/ > > > Testing > ------- > > make check on OSX and Linux. > > `./src/mesos-tests > --gtest_filter="Strict/PartitionTest.FailHealthChecksTwice/0" > --gtest_repeat=1000 --gtest_break_on_failure` > > > Thanks, > > Neil Conway > >
