> On Sept. 2, 2016, 7:20 a.m., Qian Zhang wrote: > > src/slave/slave.hpp, line 908 > > <https://reviews.apache.org/r/51477/diff/2/?file=1487468#file1487468line908> > > > > Here the key of this map is all the task IDs of the `TaskGroupInfo`, > > but actually `TaskGroupInfo` already have such info in it (all its tasks), > > so it seems a bit duplicated, maybe `hashset<TaskGroupInfo> > > queuedTaskGroups` should be enough?
hmm, `hashset` won't work since we need ordering guarrantees for sending queued tasks to the executor in the order they were received. Since, we do not have `LinkedHashSet`, I moved this to being `std::list` after discussing with Vinod. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review147632 ----------------------------------------------------------- On Sept. 6, 2016, 9:25 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51477/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 9:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6076 > https://issues.apache.org/jira/browse/MESOS-6076 > > > Repository: mesos > > > Description > ------- > > This changes implements the `runTaskGroup()` handler on the > agent ensuring that task group is sent atomically to the executor > via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()` > to go through a common handler function. Also, it ensures that all > tasks in `framework->pending`/`queuedTasks` that are killed before > running the task group result in all the tasks being killed. > > Review: https://reviews.apache.org/r/51477/ > > > Diffs > ----- > > src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 > src/slave/slave.cpp 11664779ed78c0a5913598bb7dd1bb0e793d6b93 > > Diff: https://reviews.apache.org/r/51477/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
