> On Sept. 7, 2016, 10:17 a.m., Guangya Liu wrote: > > src/slave/slave.hpp, line 1027 > > <https://reviews.apache.org/r/51477/diff/3/?file=1492260#file1492260line1027> > > > > How about const? > > Anand Mazumdar wrote: > Can you elaborate? Non member functions can't be marked `const`. Also, > did you mean `const` on the return type? > > Guangya Liu wrote: > Sorry for confuse, yes, what about the return type as const?
hmm, I don't quite understand what would the `const` specifier on the return type buy us. It's anyways a temporary rvalue that is being returned? > On Sept. 7, 2016, 10:17 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, lines 1988-1989 > > <https://reviews.apache.org/r/51477/diff/3/?file=1492261#file1492261line1988> > > > > What about adding `executor state` to the log message? > > Anand Mazumdar wrote: > Why? Also, we weren't logging the state before either. > > Guangya Liu wrote: > We actually have the executor state in log message but not here, please > refer to https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1824 > > Another point is that this is a new message that you introduced, and the > log message for `Executor::REGISTERING` and `Executor::RUNNING` are same, it > is better distinguish those log messages by adding the executor state here > for debugability. hmm, I got confused because it looked orthogonal to this change i.e. we did not do it previously either. https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1847 https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1860 I would clean this up in a separate patch like I did for a few other changes. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51477/#review147994 ----------------------------------------------------------- On Sept. 8, 2016, 5:19 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51477/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 5:19 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6076 > https://issues.apache.org/jira/browse/MESOS-6076 > > > Repository: mesos > > > Description > ------- > > This changes implements the `runTaskGroup()` handler on the > agent ensuring that task group is sent atomically to the executor > via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()` > to go through a common handler function. Also, it ensures that all > tasks in `framework->pending`/`queuedTasks` that are killed before > running the task group result in all the tasks being killed. > > Review: https://reviews.apache.org/r/51477/ > > > Diffs > ----- > > src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 > src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 > > Diff: https://reviews.apache.org/r/51477/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
