----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/#review147932 -----------------------------------------------------------
Fix it, then Ship it! src/tests/hierarchical_allocator_tests.cpp (line 3708) <https://reviews.apache.org/r/50695/#comment215237> `agentAllocation` reads a bit odd as it sounds like "an agent is given allocations". Also it really is the same as `allocation` above, we are really just trying to come up with a synonym to capture a copy in order to modify it. In this case can we just do: ``` Resources _allocation = allocation; ``` Readers of the Mesos codebase are familar with the convention of using prefixes to dintinguish different copies of the same concept. - Jiang Yan Xu On Aug. 26, 2016, 12:58 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50695/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 12:58 a.m.) > > > Review request for mesos, Benjamin Mahler, Vinod Kone, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Renamed agent used resources to `allocation` for benchmark test. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > cbed333f497016fe2811f755028796012b41db77 > > Diff: https://reviews.apache.org/r/50695/diff/ > > > Testing > ------- > > make > make check > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 911us > Added 1000 agents in 1.014938secs > Updated 1000 agents in 603347us > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/0 > (1683 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (1683 ms total) > ``` > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 861us > Added 1000 agents in 1.487206secs > round 0 allocate() took 808744us to make 0 offers after filtering 1000 offers > round 1 allocate() took 825291us to make 0 offers after filtering 1000 offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/0 > (6126 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (6126 ms total) > ``` > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 > Using 1000 agents and 1 frameworks > Added 1 frameworks in 998us > Added 1000 agents in 1.934967secs > round 0 allocate() took 810760us to make 0 offers after filtering 1000 offers > round 1 allocate() took 814886us to make 0 offers after filtering 1000 offers > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.ResourceLabels/0 > (6747 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (6747 ms total) > ``` > > > Thanks, > > Guangya Liu > >
