----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51671/#review147947 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 1403) <https://reviews.apache.org/r/51671/#comment215258> have you add the streaming function for containerId? src/slave/containerizer/mesos/containerizer.cpp (line 1405) <https://reviews.apache.org/r/51671/#comment215257> Please use 'nested' container consistently in the code base. src/slave/containerizer/mesos/containerizer.cpp (line 1416) <https://reviews.apache.org/r/51671/#comment215260> I think we should maintain the invariant that if a nested container exists in 'children' field of the parent container, the corresponding 'Container' struct should be in `containers_`. Can you move this to the private launch helper? - Jie Yu On Sept. 6, 2016, 9:53 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51671/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 9:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Implement mesos conainertizer launch for sub-container. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 89b7e8db38916d69d9b2d4fe305d4397b0859a10 > > Diff: https://reviews.apache.org/r/51671/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
