> On Sept. 6, 2016, 10:10 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1416
> > <https://reviews.apache.org/r/51671/diff/1/?file=1492311#file1492311line1416>
> >
> > I think we should maintain the invariant that if a nested container
> > exists in 'children' field of the parent container, the corresponding
> > 'Container' struct should be in `containers_`.
> >
> > Can you move this to the private launch helper?
In the second launch(), which is the logic shared by top level container and
nested container:
```
Future<bool> MesosContainerizerProcess::launch(
const ContainerID& containerId,
const ContainerConfig& containerConfig,
const map<string, string>& environment,
const SlaveID& slaveId,
bool checkpoint)
```
we will construct the `container` struct and put it into `containers_` for all
containers, either top level container or nested container.
This line just updates the 'children' list of the parent container struct. why
do we need a helper function for it?
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51671/#review147947
-----------------------------------------------------------
On Sept. 6, 2016, 2:53 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51671/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2016, 2:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph
> Wu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implement mesos conainertizer launch for sub-container.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp
> 89b7e8db38916d69d9b2d4fe305d4397b0859a10
>
> Diff: https://reviews.apache.org/r/51671/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
