----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51683/#review148109 -----------------------------------------------------------
Summarize the behavioral change in the summary? i.e., previously if role or reservation info are invalid, the result is an empty `Resources` object, now it returns a error. include/mesos/resources.hpp (line 351) <https://reviews.apache.org/r/51683/#comment215535> Comment on when the result is an Error? include/mesos/resources.hpp (lines 351 - 353) <https://reviews.apache.org/r/51683/#comment215536> To make it less cumbersome to use for a pretty common case, can we use an overload? ``` Resources flatten() const ``` As a result we don't need the default value for the argument `role` here. src/common/resources.cpp (line 1088) <https://reviews.apache.org/r/51683/#comment215544> What if `role == "*"` but `reservation.isSome()`? - Jiang Yan Xu On Sept. 6, 2016, 6:37 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51683/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 6:37 p.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-6131 > https://issues.apache.org/jira/browse/MESOS-6131 > > > Repository: mesos > > > Description > ------- > > Avoided resource validation when flatten resources. > > > Diffs > ----- > > include/mesos/resources.hpp 87828aa5e4818efd40dd72dc199669281b8a15ae > include/mesos/v1/resources.hpp 27bdd275277edc60d97b720e596f21e8e8f8dc27 > src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 > src/common/resources.cpp 77ee92193de1f34131f7a86b7d16731c9c3e17e2 > src/examples/balloon_framework.cpp 5613ff0c61e2d2f84684a206debc97dcb8b2c0d3 > src/examples/disk_full_framework.cpp > 1221f83d495f7c1ee1bcbcfe067e303db0a921eb > src/examples/dynamic_reservation_framework.cpp > 850bb2a5b243dd5d5a8b6476570b4f943fde6185 > src/examples/long_lived_framework.cpp > 7c57eb5e4a34208504475013690ae8e3cae74155 > src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 > src/examples/test_http_framework.cpp > 441e86c88b035d9a268b8b51b95da3e1eb842a62 > src/master/http.cpp 525ef6cd7545d25f3ac89a6325ace6e6d768262a > src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb > src/tests/hierarchical_allocator_tests.cpp > 24698ffc9f72bc1e144e5107412f5e7d9c4f7105 > src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f > src/tests/persistent_volume_endpoints_tests.cpp > 266c2a0ff4a99baa96a7c4980f076755603256a9 > src/tests/reservation_endpoints_tests.cpp > bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1 > src/tests/reservation_tests.cpp 000957826011bf28f7550a83db3e60a796162fb3 > src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb > src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d > src/v1/resources.cpp 4ba5bf87c9b9fef67eeb447a3f3b520f1e81ad77 > > Diff: https://reviews.apache.org/r/51683/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
