-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51683/
-----------------------------------------------------------

(Updated 九月 15, 2016, 8:48 a.m.)


Review request for mesos, Benjamin Mahler and Jiang Yan Xu.


Bugs: MESOS-6131
    https://issues.apache.org/jira/browse/MESOS-6131


Repository: mesos


Description
-------

1) Previously if role or reservation info are invalid,
the result is an empty Resources object, now it returns
an error.
2) Added a new flatten() method to flatten resources with
star role and empty reservation.


Diffs (updated)
-----

  include/mesos/resources.hpp 7ba422d57d47777e058c682df9aa780557782423 
  include/mesos/v1/resources.hpp add48c7baf8fabf5cc443d60a6c96d2902fc67de 
  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
  src/common/resources.cpp aa4d6b5af9c24e90cefaa4f4c1ad593966eceb7c 
  src/examples/dynamic_reservation_framework.cpp 
850bb2a5b243dd5d5a8b6476570b4f943fde6185 
  src/examples/test_framework.cpp a83766a92617d50eadd92ec55113e049a7290d03 
  src/examples/test_http_framework.cpp 441e86c88b035d9a268b8b51b95da3e1eb842a62 
  src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb 
  src/tests/hierarchical_allocator_tests.cpp 
7705de95a3916310baf4daca62aab1e6b1ca3cb3 
  src/tests/mesos.hpp fa6789b0436b11a4f1baade9b5cbae0a04e1687d 
  src/tests/persistent_volume_endpoints_tests.cpp 
266c2a0ff4a99baa96a7c4980f076755603256a9 
  src/tests/reservation_endpoints_tests.cpp 
bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1 
  src/tests/reservation_tests.cpp 93e95a9ba33051b9506714a9578118569c09f7e6 
  src/tests/resources_tests.cpp 157b9f65945b864e463c62a89281a3c80a85929d 
  src/tests/role_tests.cpp 162c9414a70723a212cfd39ac5c0b8325c3f3b5d 
  src/v1/resources.cpp 4b66acbba92bc6316fa77ae4dcabce9fab65f7b5 

Diff: https://reviews.apache.org/r/51683/diff/


Testing
-------

make
make check

```
./bin/mesos-tests.sh  --gtest_filter="ResourcesOperationTest.FlattenResources"
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ResourcesOperationTest
[ RUN      ] ResourcesOperationTest.FlattenResources
[       OK ] ResourcesOperationTest.FlattenResources (3 ms)
[----------] 1 test from ResourcesOperationTest (3 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (24 ms total)
[  PASSED  ] 1 test.
```


Thanks,

Guangya Liu

Reply via email to