> On Sept. 8, 2016, 10:41 p.m., Jiang Yan Xu wrote: > > src/tests/resources_tests.cpp, line 834 > > <https://reviews.apache.org/r/51517/diff/1/?file=1488441#file1488441line834> > > > > Not yours, but starting from here this is already incorrect: persistent > > volumes don't have host paths. This is currently not captured by validation > > IIUC, just ignored by the agent. > > > > Anyways, it'll involve some refactoring and reordering to fix this test > > so let's do it later.
Will open a separate JIRA for this. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51517/#review148260 ----------------------------------------------------------- On Aug. 30, 2016, 10:22 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51517/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 10:22 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6060 > https://issues.apache.org/jira/browse/MESOS-6060 > > > Repository: mesos > > > Description > ------- > > We also log the disk type (MOUNT or PATH) for each persistent disk as > well as the root path for these disks while logging resources. Note > that this is logged only when source is present, otherwise there is > no additional content logged. > > > Diffs > ----- > > src/common/resources.cpp a5f5902d8f7f2757e3aee35619bff5cc3a52f29b > src/tests/resources_tests.cpp 4932d95f4e78cae764b89472373e13527b4354a2 > src/v1/resources.cpp 172217505d80d66cb7e10b3635dc273229313601 > > Diff: https://reviews.apache.org/r/51517/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
