----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51517/#review148965 -----------------------------------------------------------
Ship it! Will commit with the following edits. src/common/resources.cpp (lines 1746 - 1747) <https://reviews.apache.org/r/51517/#comment216495> Let's just use `UNREACHABLE();` here as it's impossible to be anything else. src/v1/resources.cpp (lines 1749 - 1750) <https://reviews.apache.org/r/51517/#comment216496> Ditto. - Jiang Yan Xu On Sept. 9, 2016, 9:26 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51517/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 9:26 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6060 > https://issues.apache.org/jira/browse/MESOS-6060 > > > Repository: mesos > > > Description > ------- > > We also log the disk type (MOUNT or PATH) for each persistent disk as > well as the root path for these disks while logging resources. Note > that this is logged only when source is present, otherwise there is > no additional content logged. > > > Diffs > ----- > > src/common/resources.cpp 77ee92193de1f34131f7a86b7d16731c9c3e17e2 > src/tests/resources_tests.cpp f627862870279e5a778aa83e1ddcaa88c27ba1cb > src/v1/resources.cpp 4ba5bf87c9b9fef67eeb447a3f3b520f1e81ad77 > > Diff: https://reviews.apache.org/r/51517/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
