> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411
> > <https://reviews.apache.org/r/51631/diff/1/?file=1491031#file1491031line408>
> >
> > Why moving these code here? Can you please let me know what is the
> > problem if we still keep these code in its original location?
Suppose we failed at
```
if (containerConfig.has_user()) {
Try<Nothing> chown = os::chown(
containerConfig.user(),
path,
false);
if (chown.isError()) {
return Failure(
"Failed to chown the cgroup at "
"'" + path + "': " + chown.error());
}
```
but we have
```
Try<Nothing> create = cgroups::create(
hierarchy,
infos[containerId]->cgroup);
```
before.
Then the cgroup would not be destroyed if we don't
`infos[containerId]->subsystems.insert(subsystem->name());`.
> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 486-492
> > <https://reviews.apache.org/r/51631/diff/1/?file=1491031#file1491031line486>
> >
> > Here we may assign pid to cgroup for a single hierarchy multiple times.
> > For example, in the case of CPU:
> > ```
> > /cgroup/cpu,cpuacct -> cpu
> > /cgroup/cpu,cpuacct -> cpuacct
> > ```
> > With your logic here, we will call `cgroups::assign()` twice for the
> > hierarchy `/cgroup/cpu,cpuacct`.
Because we have `break` above, so this would not happen.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51631/#review147806
-----------------------------------------------------------
On Sept. 11, 2016, 10:31 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51631/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 10:31 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-6063
> https://issues.apache.org/jira/browse/MESOS-6063
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Recover newly added cgroups subsystems on existing containers would
> fail, and continue to perform the `update` and other operations of
> the newly added subsystems on them don't make sense. This patch add
> the tracking for the recovered or prepared cgroups subsystems of a
> container and skip performing unnecessary subsystem operations on the
> container if the subsystem is never recovered or prepared.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp
> 38d1428f5425566502747d2a8394e246e0b3fd9e
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> 8b6dfde366caf82d30afb891c8f1337ceed12157
>
> Diff: https://reviews.apache.org/r/51631/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
