> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > <https://reviews.apache.org/r/51631/diff/1/?file=1491031#file1491031line290> > > > > I do not think we need this comment because I think if recover fails, > > the agent will exit, so we do not have chance (or actually do not need) to > > do any cleanup.
We call cleanup before return `Failure` in `__recover`, I think this comment still correct here? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147806 ----------------------------------------------------------- On Sept. 11, 2016, 4:04 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51631/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 4:04 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-6063 > https://issues.apache.org/jira/browse/MESOS-6063 > > > Repository: mesos > > > Description > ------- > > Recover newly added cgroups subsystems on existing containers would > fail, and continue to perform the `update` and other operations of > the newly added subsystems on them don't make sense. This patch add > the tracking for the recovered or prepared cgroups subsystems of a > container and skip performing unnecessary subsystem operations on the > container if the subsystem is never recovered or prepared. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 38d1428f5425566502747d2a8394e246e0b3fd9e > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 8b6dfde366caf82d30afb891c8f1337ceed12157 > > Diff: https://reviews.apache.org/r/51631/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
