----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148441 -----------------------------------------------------------
Fix it, then Ship it! Thanks for the cleanup! src/tests/containerizer/cgroups_isolator_tests.cpp (lines 61 - 86) <https://reviews.apache.org/r/51783/#comment215900> Can we simply use nobody, rather than adding a new user. If test crashes, we'll be leaking a user. src/tests/containerizer/cgroups_isolator_tests.cpp (line 89) <https://reviews.apache.org/r/51783/#comment215901> Please add a short summary of this test. src/tests/containerizer/cgroups_isolator_tests.cpp (lines 96 - 97) <https://reviews.apache.org/r/51783/#comment215902> ``` vector<string> subsystems = { CGROUP_SUBSYSTEM_CPU_NAME, CGROUP_SUBSYSTEM_CPUACCT_NAME, CGROUP_SUBSYSTEM_DEVICES_NAME, CGROUP_SUBSYSTEM_MEMORY_NAME, CGROUP_SUBSYSTEM_NET_CLS_NAME, CGROUP_SUBSYSTEM_PERF_EVENT_NAME, }; vector<string> isolators; foreach (const string& subsystem, subsystems) { isolators.push_back("cgroups/" + subsystem); } flags.isolation = strings::join(",", isolators); ``` src/tests/containerizer/cgroups_isolator_tests.cpp (line 115) <https://reviews.apache.org/r/51783/#comment215903> I'd put each parameter in a new line. - Jie Yu On Sept. 11, 2016, 4:45 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51783/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 4:45 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Refactored `UserCgroupsIsolatorTest`. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > c4e467c8227f9e4129b05d173812592f39a04e06 > > Diff: https://reviews.apache.org/r/51783/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
