> On Sept. 12, 2016, 4:03 a.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp, lines 97-98 > > <https://reviews.apache.org/r/51783/diff/5/?file=1495689#file1495689line97> > > > > ``` > > vector<string> subsystems = { > > CGROUP_SUBSYSTEM_CPU_NAME, > > CGROUP_SUBSYSTEM_CPUACCT_NAME, > > CGROUP_SUBSYSTEM_DEVICES_NAME, > > CGROUP_SUBSYSTEM_MEMORY_NAME, > > CGROUP_SUBSYSTEM_NET_CLS_NAME, > > CGROUP_SUBSYSTEM_PERF_EVENT_NAME, > > }; > > > > vector<string> isolators; > > foreach (const string& subsystem, subsystems) { > > isolators.push_back("cgroups/" + subsystem); > > } > > > > flags.isolation = strings::join(",", isolators); > > ```
Because our isolators names don't mapping to subsystem names exactly, we could not do this. For example, `cgroups/cpuacct`, `cgroups/memory` doesn't exist in isolation flag. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148441 ----------------------------------------------------------- On Sept. 12, 2016, 4:32 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51783/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 4:32 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Refactor `UserCgroupsIsolatorTest.ROOT_CGROUPS_PERF_UserCgroup` and > rename to `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_NET_CLS_UserCgroup`. > > > Diffs > ----- > > src/tests/containerizer/cgroups_isolator_tests.cpp > c4e467c8227f9e4129b05d173812592f39a04e06 > > Diff: https://reviews.apache.org/r/51783/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
