> On Sept. 13, 2016, 11:01 a.m., Qian Zhang wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 517-523 > > <https://reviews.apache.org/r/51794/diff/1/?file=1496214#file1496214line517> > > > > I think we may not need these code anymore since `100.5` has already > > covered both `big` and `decimal`. > > haosdent huang wrote: > I think it still make sense that we test `100` and `100.5` separately. If > we only have `100.5` and we failed at this test case, we not sure it failed > because of BigQuota or Decimal. But if we test `100` first, we could verify > whether BigQuota works or not.
Agree, then I think we may need to handle them as two separate tests: one for big quota (`ROOT_CGROUPS_CFS_Big_Quota`), another one for decimal quota (`ROOT_CGROUPS_CFS_Decimal_Quota`) which seems more clear to me. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/#review148641 ----------------------------------------------------------- On Sept. 13, 2016, 4:22 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51794/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 4:22 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Test writing CFS quota with decimal and rename > `ROOT_CGROUPS_CFS_Big_Quota` to `ROOT_CGROUPS_CFS_BigQuotaDecimal`. > > > Diffs > ----- > > src/tests/containerizer/cgroups_tests.cpp > 821c7860ab424bcfadbf597902e046bce9ba3044 > > Diff: https://reviews.apache.org/r/51794/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
