> On Sept. 13, 2016, 6:02 p.m., Joseph Wu wrote: > > src/tests/containerizer/cgroups_tests.cpp, line 532 > > <https://reviews.apache.org/r/51794/diff/4/?file=1497615#file1497615line532> > > > > This test is actually equivalent to `ROOT_CGROUPS_CFS_BigQuota`: > > ``` > > ../../src/tests/containerizer/cgroups_tests.cpp:532:28: error: implicit > > conversion from 'double' to 'int64_t' (aka 'long') changes value from 100.5 > > to 100 [-Werror,-Wliteral-conversion] > > Duration quota = Seconds(100.5); // Big quota with decimal. > > ``` > > > > You should use `Duration quota = Milliseconds(100500);` instead, which > > is technically a decimal number of seconds. > > haosdent huang wrote: > Thx @kaysoky! I saw the unit of cfs quota is microseconds, do you think > we should revert this patch?
I'm lacking context on how the "big decimal" test is different than the "big" test :) If the intent behind the two tests are identical, then it would make sense to revert. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/#review148831 ----------------------------------------------------------- On Sept. 13, 2016, 2:01 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51794/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 2:01 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Add a new test case `ROOT_CGROUPS_CFS_BigQuotaDecimal` to test updating > CFS quota with decimal. > > > Diffs > ----- > > src/tests/containerizer/cgroups_tests.cpp > 821c7860ab424bcfadbf597902e046bce9ba3044 > > Diff: https://reviews.apache.org/r/51794/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
