> On Sept. 13, 2016, 2:59 p.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 55-59 > > <https://reviews.apache.org/r/51737/diff/2/?file=1497076#file1497076line55> > > > > s/::Error/Error/g
We need the `::Error` to disambiguate the global definition of `Error` from `spec::Error`. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review148728 ----------------------------------------------------------- On Sept. 12, 2016, 7:27 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51737/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 7:27 p.m.) > > > Review request for mesos, haosdent huang, Jie Yu, switched to 'mcypark', and > Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > Added `PluginError` to simplify error reporting for CNI plugins. > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp > 11c03fdf8a85414d20704299103e22be7d844f80 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp > 85547533b0b13011615b512ec8c71b7545f33324 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp > 2d0187beaf0d20e87d5a9ff80f5672ce7b8cc53b > > Diff: https://reviews.apache.org/r/51737/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
