----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/#review148802 -----------------------------------------------------------
Fix it, then Ship it! src/master/validation.cpp (line 56) <https://reviews.apache.org/r/51865/#comment216315> do we need this `internal`? src/master/validation.cpp (lines 61 - 63) <https://reviews.apache.org/r/51865/#comment216314> This is not necessary, because it is a required field. - Gilbert Song On Sept. 13, 2016, 3:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51865/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 3:47 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/validation.cpp 137b9f912029d6b0287b49541d1af9bb1fdb80b3 > > Diff: https://reviews.apache.org/r/51865/diff/ > > > Testing > ------- > > make check on Mac OS > > > Thanks, > > Alexander Rukletsov > >
