> On Sept. 13, 2016, 11:30 p.m., Gilbert Song wrote: > > src/master/validation.cpp, lines 61-63 > > <https://reviews.apache.org/r/51865/diff/1/?file=1498010#file1498010line61> > > > > This is not necessary, because it is a required field.
That's correct, however, due to https://issues.apache.org/jira/browse/MESOS-4997 we may change all required enums to optional soon. This code already does what it should. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51865/#review148802 ----------------------------------------------------------- On Sept. 13, 2016, 10:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51865/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 10:47 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/validation.cpp 137b9f912029d6b0287b49541d1af9bb1fdb80b3 > > Diff: https://reviews.apache.org/r/51865/diff/ > > > Testing > ------- > > make check on Mac OS > > > Thanks, > > Alexander Rukletsov > >
