> On Sept. 13, 2016, 5:41 p.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 595-601 > > <https://reviews.apache.org/r/51857/diff/1/?file=1497935#file1497935line595> > > > > Looks like this assumes 2-levels of nesting (maximum). You might as > > well recurse up to the upper-most parent and use that ContainerNetwork. > > Avinash sridharan wrote: > They should be identical right? So why do the recursion?
Ah, the `infos` saves every launched container... which works. The additional memory seems minimal too. In that case, you can remove the `CHECK` and do this instead: ``` containerNetworks = infos.at(containerId.parent())->containerNetworks; ``` - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review148825 ----------------------------------------------------------- On Sept. 13, 2016, 5:02 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51857/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 5:02 p.m.) > > > Review request for Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-6156 > https://issues.apache.org/jira/browse/MESOS-6156 > > > Repository: mesos > > > Description > ------- > > Modified the `prepare` method to be aware of nested containers. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 822f11eab5b00c014563322a8c3b2c14cb440e0b > > Diff: https://reviews.apache.org/r/51857/diff/ > > > Testing > ------- > > make > make check > and > sudo ./bin/mesos-tests.sh > > The only tests that failed were the SUDO make check tests: > [ FAILED ] 3 tests, listed below: > [ FAILED ] CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen > [ FAILED ] CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS > [ FAILED ] LinuxFilesystemIsolatorTest.ROOT_RecoverOrphanedPersistentVolume > > > Thanks, > > Avinash sridharan > >
