-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51857/
-----------------------------------------------------------

(Updated Sept. 16, 2016, 4:21 p.m.)


Review request for Gilbert Song, Jie Yu, Joseph Wu, and Qian Zhang.


Changes
-------

Added checks to ensure that `container_info` is set for child containers, and 
that their `NetworkInfo` is not set. Setting `NetworkInfo` in `container_info` 
for a child container implies that parent and child have different network 
namespaces which is not currently supported.


Bugs: MESOS-6156
    https://issues.apache.org/jira/browse/MESOS-6156


Repository: mesos


Description
-------

Modified the `prepare` method to be aware of nested containers.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
822f11eab5b00c014563322a8c3b2c14cb440e0b 

Diff: https://reviews.apache.org/r/51857/diff/


Testing
-------

make 
make check
and
sudo ./bin/mesos-tests.sh

The only tests that failed were the SUDO make check tests:
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen
[  FAILED  ] CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS
[  FAILED  ] LinuxFilesystemIsolatorTest.ROOT_RecoverOrphanedPersistentVolume


Thanks,

Avinash sridharan

Reply via email to