----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51891/#review148959 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Sept. 14, 2016, 3:04 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51891/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 3:04 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > If GC occurs concurrently with another operation that changes the > registry (e.g., reregistration of an agent that is also going to be > removed by the GC operation), the GC might not be able to prune as > many entries as expected from the registry. > > Along the way, this commit updates the master's logging to emit > a warning in this situation. It also corrects an inaccuracy: we > should report the number of agents we actually pruned from the > registry, not the number we _attempted_ to reclaim. > > > Diffs > ----- > > src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > > Diff: https://reviews.apache.org/r/51891/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
