----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51891/#review149023 -----------------------------------------------------------
Bad patch! Reviews applied: [51891, 51845, 51805, 51707, 51653, 51706, 51021, 51377, 51376, 51375, 51374, 51371, 51020, 50846, 50845, 50844, 50707, 50706, 50705, 50704, 50703, 50702, 50701, 50700, 50699, 50422, 50418, 50417, 50416, 50235] Failed command: ./support/apply-review.sh -n -r 51375 Error: 2016-09-15 03:57:58 URL:https://reviews.apache.org/r/51375/diff/raw/ [8917/8917] -> "51375.patch" [1] error: patch failed: src/Makefile.am:988 error: src/Makefile.am: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15253/console - Mesos ReviewBot On Sept. 14, 2016, 3:04 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51891/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 3:04 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > If GC occurs concurrently with another operation that changes the > registry (e.g., reregistration of an agent that is also going to be > removed by the GC operation), the GC might not be able to prune as > many entries as expected from the registry. > > Along the way, this commit updates the master's logging to emit > a warning in this situation. It also corrects an inaccuracy: we > should report the number of agents we actually pruned from the > registry, not the number we _attempted_ to reclaim. > > > Diffs > ----- > > src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151 > src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 > > Diff: https://reviews.apache.org/r/51891/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
