> On Sept. 19, 2016, 6:20 a.m., Alexander Rukletsov wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 1653
> > <https://reviews.apache.org/r/52020/diff/1/?file=1501903#file1501903line1653>
> >
> >     This looks fine: 4 spaces after '('.
> 
> Guangya Liu wrote:
>     Does the indent always start from begining? 
>     
>     1) 
> https://github.com/apache/mesos/blob/master/src/cli/execute.cpp#L645-L646
>     2) 
> https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#function-definitioninvocation

```
if (!remainingClusterResources.contains(
```
In this case, the code should be aligned based on the "`.contains(`", rather 
than on the "`if (`".  So the existing alignment is alright.

---

You may see "`if (`" alignment in cases like:
```
if (really_really_really_long_boolean_expression &&
    other_really_long_boolean_expression)
```


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52020/#review149464
-----------------------------------------------------------


On Sept. 18, 2016, 6:59 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52020/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2016, 6:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed indent in allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2d56bd011f2c87c67a02d0ae467a4a537d36867e 
> 
> Diff: https://reviews.apache.org/r/52020/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to