----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/#review149773 -----------------------------------------------------------
Ship it! LGTM. - Joseph Wu On Sept. 19, 2016, 11:47 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51065/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 11:47 a.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > This changes the SSL helpers in libprocess to generate > certs using a hostname determined using the same address > that is advertised by libprocess. This assures that > validation of the certificates will succeed. The test > `SSLTest.BasicSameProcess` is also updated to accommodate > this change. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 2ad623a5ea3b3286983e895010af756f14f51b64 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > a5ac03969694c4345c2c5004051b08b6d1da8555 > > Diff: https://reviews.apache.org/r/51065/diff/ > > > Testing > ------- > > `make check` on Ubuntu 14.04 > > > Thanks, > > Greg Mann > >
