----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41613/#review149807 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 902) <https://reviews.apache.org/r/41613/#comment217534> I see that the disk on the agent is still in `role1`, rather than `DEFAULT_ROLE`, i.e. `default-role`. It seemss like this wouldn't work? src/tests/persistent_volume_tests.cpp (lines 944 - 952) <https://reviews.apache.org/r/41613/#comment217535> I see that the disks on the task is still in `role1`, rather than `DEFAULT_ROLE`, i.e. `default-role`. It seemss like this wouldn't work? - Michael Park On Sept. 21, 2016, 5:55 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41613/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 5:55 a.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Added `DEFAULT_ROLE` constant to persistent volume tests. > > > Diffs > ----- > > src/tests/mesos.hpp 7095101cc4b19d7ccbfcfe1c9681d4a591983a95 > src/tests/persistent_volume_tests.cpp > c38d8484fbd62b36bf124a96d17c8cae5e51e594 > > Diff: https://reviews.apache.org/r/41613/diff/ > > > Testing > ------- > > `GTEST_FILTER="*PersistentVolumeTest*" bin/mesos-tests.sh` > > > Thanks, > > Greg Mann > >
