-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52164/#review150142
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/slave.cpp (line 3087)
<https://reviews.apache.org/r/52164/#comment218011>

    weren't you going to remove the corresponding evolve method?


- Vinod Kone


On Sept. 23, 2016, 3:24 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52164/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2016, 3:24 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6227
>     https://issues.apache.org/jira/browse/MESOS-6227
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the field `ContainerID` to the executor `SUBSCRIBED`
> event. This allows the default executor/other custom executors to
> then launch nested containers. This is needed as the executors need
> to let the agent know of the parent container ID when they make the
> `LAUNCH_NESTED_CONTAINER` call. This change also implements the
> logic on the agent to send the event to the executor.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.proto 
> 0d31406a70d6b7d9030c1f157a7869a2e8f1879f 
>   include/mesos/v1/executor/executor.proto 
> f661b71cecb96a9971c687f117625ef242749394 
>   src/slave/slave.cpp 11e9c8af87aa5153f72f2a20cc578fe3d729b153 
>   src/tests/executor_http_api_tests.cpp 
> fd322ee267b2f0d4bf250db15027d61f1fc74a57 
> 
> Diff: https://reviews.apache.org/r/52164/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to