----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/#review150316 -----------------------------------------------------------
src/launcher/default_executor.cpp (line 132) <https://reviews.apache.org/r/52149/#comment218250> don't you want to check `if (!killed)`? src/launcher/default_executor.cpp (line 427) <https://reviews.apache.org/r/52149/#comment218251> just inline this function. src/launcher/default_executor.cpp (line 482) <https://reviews.apache.org/r/52149/#comment218252> log a statement here. src/launcher/default_executor.cpp (line 501) <https://reviews.apache.org/r/52149/#comment218253> Log here? src/launcher/default_executor.cpp (line 753) <https://reviews.apache.org/r/52149/#comment218254> log a statement here. src/launcher/default_executor.cpp (lines 762 - 775) <https://reviews.apache.org/r/52149/#comment218255> I think it is worth logging insided onFailed and onDiscarded handlers before firing a delay. - Vinod Kone On Sept. 23, 2016, 3:28 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52149/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 3:28 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6227 > https://issues.apache.org/jira/browse/MESOS-6227 > > > Repository: mesos > > > Description > ------- > > This change adds support for waiting on child containers via the > `WAIT_NESTED_CONTAINER` call on the Agent API. If the connection > fails due to a temporary network blip, it reconnects with the > agent. > > > Diffs > ----- > > src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c > > Diff: https://reviews.apache.org/r/52149/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
