----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52149/#review150433 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp (line 103) <https://reviews.apache.org/r/52149/#comment218416> log a statement here? src/launcher/default_executor.cpp (line 462) <https://reviews.apache.org/r/52149/#comment218419> LOG(INFO) maybe because it is making an API call? src/launcher/default_executor.cpp (line 827) <https://reviews.apache.org/r/52149/#comment218414> Add a comment here for why the delay is needed? - Vinod Kone On Sept. 26, 2016, 4:31 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52149/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 4:31 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6227 > https://issues.apache.org/jira/browse/MESOS-6227 > > > Repository: mesos > > > Description > ------- > > This change adds support for waiting on child containers via the > `WAIT_NESTED_CONTAINER` call on the Agent API. If the connection > fails due to a temporary network blip, it reconnects with the > agent. > > > Diffs > ----- > > src/launcher/default_executor.cpp 2102fe8d70f0960fed669e1c4f0d6b6cd4af261c > > Diff: https://reviews.apache.org/r/52149/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
