----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/#review150358 -----------------------------------------------------------
src/linux/ns.hpp (lines 427 - 430) <https://reviews.apache.org/r/51277/#comment218324> Memory leak? Who is going to cleanup the stack? src/linux/ns.hpp (lines 479 - 486) <https://reviews.apache.org/r/51277/#comment218321> Can you add some comment about why waitpid is necessary here (e.g., avoid zombie processes). Also, add note that although waitpid is blocking here, it should be very short as the child is expected to exit soon. src/linux/ns.hpp (line 482) <https://reviews.apache.org/r/51277/#comment218322> what if 'waitpid' failed? For instance, what if EINTR is encountered (i.e., the current process received a signal)? src/linux/ns.hpp (lines 525 - 532) <https://reviews.apache.org/r/51277/#comment218323> Ditto. src/linux/ns.hpp (line 535) <https://reviews.apache.org/r/51277/#comment218325> you can use 'raise' here - Jie Yu On Sept. 25, 2016, 4:33 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51277/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2016, 4:33 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Added an 'ns::clone' helper. > > > Diffs > ----- > > src/linux/ns.hpp 2d6c359ed24d6e964882f34df60d8182491a27c9 > src/tests/containerizer/ns_tests.cpp > 6aa5ade9a25356057ace609fb875f070aca1ec0e > > Diff: https://reviews.apache.org/r/51277/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Hindman > >
