----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51785/ -----------------------------------------------------------
(Updated Sept. 26, 2016, 3:27 p.m.) Review request for hbase. Changes ------- The recent update is splitting MemStoreCompactorIterator into two classes: MemStoreCompactorSegmentsIterator and MemStoreMergerSegmentsIterator, both doing iterations over list of segments (first with SQM and second without). The common between two classes is held in the abstract class MemStoreSegmentsIterator, which both new classes extend. Repository: hbase-git Description ------- This is a step toward final compacting memstore that allowes two modes of work: index-compaction and data-compaction. The index-compaction means that when the new segment is pushed into the pipeline, it is flattened and probably merged with old segments in the pipeline. The new merge "feature" induces no data-copy-compaction and no speculative SQM scan. The compacting memstore of the data-compaction type means the usage of the data-copy-compaction. Diffs (updated) ----- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java 177f222 hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java 6a13f43 hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java 3ca4b0c hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java 12b7916 hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java 714ffe3 hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorIterator.java 2eafb42 hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorSegmentsIterator.java PRE-CREATION hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreMergerSegmentsIterator.java PRE-CREATION hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSegmentsIterator.java PRE-CREATION hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentFactory.java 510ebbd hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/VersionedSegmentsList.java 2e8bead hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java 211a6d8 hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellArrayMapMemStore.java fefe2c1 hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java 6bfaa59 hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWalAndCompactingMemStoreFlush.java 74826b0 Diff: https://reviews.apache.org/r/51785/diff/ Testing ------- Thanks, Anastasia Braginsky
