> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote:
> > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java,
> > line 398
> > <https://reviews.apache.org/r/51785/diff/6/?file=1510146#file1510146line398>
> >
> > Seeing the tests using this method.. Why those tests can not create a
> > new instance of CompactingMemstore (After setting the required conf and
> > passing that)? Give this kind of setters if not aviodable. I feel we can
> > do the test with out this also.. Pls consider. In Memstorecompactor
> > constructor just initailize the action type.
In the current version of the tests it is impossible to create a new instance
of CompactingMemstore after setting the required conf. This whould be something
like this:
memstore.getConfiguration().set("hbase.hregion.compacting.memstore.type",
"data-compaction");
this.memstore = new CompactingMemStore(HBaseConfiguration.create(),
CellComparator.COMPARATOR, store, regionServicesForStores);
This is problematic because the configuration is created per memstore. This can
be improved, but I don't want to do it under this JIRA. I think all those
Compacting MemStore tests need to be refined and new JIRA need to opened for
that. This JIRA is opened for too long and already includes too many code
lines. Let's finish with it.
- Anastasia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51785/#review150430
-----------------------------------------------------------
On Sept. 26, 2016, 3:27 p.m., Anastasia Braginsky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51785/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2016, 3:27 p.m.)
>
>
> Review request for hbase.
>
>
> Repository: hbase-git
>
>
> Description
> -------
>
> This is a step toward final compacting memstore that allowes two modes of
> work: index-compaction and data-compaction.
>
> The index-compaction means that when the new segment is pushed into the
> pipeline, it is flattened and probably merged with old segments in the
> pipeline. The new merge "feature" induces no data-copy-compaction and no
> speculative SQM scan.
> The compacting memstore of the data-compaction type means the usage of the
> data-copy-compaction.
>
>
> Diffs
> -----
>
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java
> 177f222
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionPipeline.java
> 6a13f43
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HeapMemStoreLAB.java
> 3ca4b0c
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ImmutableSegment.java
> 12b7916
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java
> 714ffe3
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorIterator.java
> 2eafb42
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactorSegmentsIterator.java
> PRE-CREATION
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreMergerSegmentsIterator.java
> PRE-CREATION
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSegmentsIterator.java
> PRE-CREATION
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentFactory.java
> 510ebbd
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/VersionedSegmentsList.java
> 2e8bead
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java
> 211a6d8
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellArrayMapMemStore.java
> fefe2c1
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
> 6bfaa59
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWalAndCompactingMemStoreFlush.java
> 74826b0
>
> Diff: https://reviews.apache.org/r/51785/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anastasia Braginsky
>
>
