----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review150729 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/tests/health_check_tests.cpp (lines 1373 - 1375) <https://reviews.apache.org/r/52357/#comment218783> Let's use ```` os::mktemp(path::join(os::getcwd(), "XXXXXX")); ``` here and it would be clean automatically when test cases tear down. So that we could avoid leak files in `/tmp`. I think `HealthCheckTest.HealthStatusChange` need to be updated as well, but let's do it in a separate patch. src/tests/health_check_tests.cpp (lines 1389 - 1390) <https://reviews.apache.org/r/52357/#comment218782> It would be better that we add a comment said `9999` is the grace_period. Or use `createTask()` instead of `populateTasks`. src/tests/health_check_tests.cpp (lines 1414 - 1415) <https://reviews.apache.org/r/52357/#comment218784> Could remove this if we use ``` os::mktemp(path::join(os::getcwd(), "XXXXXX")); ``` - haosdent huang On Sept. 28, 2016, 5 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52357/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 5 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-6170 > https://issues.apache.org/jira/browse/MESOS-6170 > > > Repository: mesos > > > Description > ------- > > The health check library would ignore all failures until after the end > of the grace period. > > This behaviour was misleading. With the changes in this commit, once a > health check succeeds for the first time, the grace period rule for > failures is not be applied any more. > > > Diffs > ----- > > src/health-check/health_checker.cpp > ea93132f2a5d4828c75005f102eddc4c3131599d > src/tests/health_check_tests.cpp e6b02f23dc1b1b84381ab0af0e3df5918b60ae40 > > Diff: https://reviews.apache.org/r/52357/diff/ > > > Testing > ------- > > Manual tests using Marathon. > Added a new unit test and verified that it fails without the change, but > succeeds with it. > > > Thanks, > > Gastón Kleiman > >
