----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52357/#review151335 -----------------------------------------------------------
Patch looks great! Reviews applied: [52357] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 4, 2016, 1:18 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52357/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 1:18 p.m.) > > > Review request for mesos, Alexander Rukletsov and haosdent huang. > > > Bugs: MESOS-6170 > https://issues.apache.org/jira/browse/MESOS-6170 > > > Repository: mesos > > > Description > ------- > > The health check library would ignore all failures until after the end > of the grace period. > > This behaviour was misleading. With the changes in this commit, once a > health check succeeds for the first time, the grace period rule for > failures is not be applied any more. > > > Diffs > ----- > > src/health-check/health_checker.cpp > ea93132f2a5d4828c75005f102eddc4c3131599d > src/tests/health_check_tests.cpp f4a63e2f5def022bf4469920861e6a5af229af96 > > Diff: https://reviews.apache.org/r/52357/diff/ > > > Testing > ------- > > Manual tests using Marathon. > Added a new unit test and verified that it fails without the change, but > succeeds with it. > > > Thanks, > > Gastón Kleiman > >
