----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review150743 -----------------------------------------------------------
src/slave/slave.cpp (lines 4195 - 4198) <https://reviews.apache.org/r/52311/#comment218799> The logic you've added in this diff should go above here. Notice the `return task.executor();`. Custom executors will return there. The special case for the "default" executor is everything below these lines. src/slave/slave.cpp (lines 4340 - 4346) <https://reviews.apache.org/r/52311/#comment218800> Once you've moved the logic block up to the top of this method, you may be able to simplify this logic too (remove duplication). - Joseph Wu On Sept. 27, 2016, 12:41 p.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52311/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 12:41 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Pass the user value from executor of switch_user flag is set. > > > Diffs > ----- > > src/slave/slave.cpp 7073be44eab6187390922a74cf72facc29bf2ad4 > > Diff: https://reviews.apache.org/r/52311/diff/ > > > Testing > ------- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
