> On Sept. 28, 2016, 6:03 p.m., Joseph Wu wrote: > > src/slave/slave.cpp, lines 4340-4346 > > <https://reviews.apache.org/r/52311/diff/1/?file=1511095#file1511095line4340> > > > > Once you've moved the logic block up to the top of this method, you may > > be able to simplify this logic too (remove duplication).
This logic was moved to above mentioned code. Also I removed the code duplicate inside that function. - Sivaram ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review150743 ----------------------------------------------------------- On Sept. 29, 2016, 6:51 p.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52311/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 6:51 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Set the executorInfo user before the custom executor code flow. > > > Diffs > ----- > > src/slave/slave.cpp 7073be44eab6187390922a74cf72facc29bf2ad4 > > Diff: https://reviews.apache.org/r/52311/diff/ > > > Testing > ------- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
