> On Sept. 9, 2016, 8:09 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3609 > > <https://reviews.apache.org/r/51028/diff/3/?file=1494820#file1494820line3609> > > > > 1) The `allocationRuns.load()` actually include the number of > > allocations caused by adding agent, we should remove this number here. > > 2) kill the period at the end > > Jacob Janco wrote: > Ended up using the default callback set on initialize.
Thus not carrying the offer callback counter at all. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review148314 ----------------------------------------------------------- On Sept. 28, 2016, 9:16 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 9:16 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Ensure that expected > allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 46553f6d501deb37862dd5ba48be1c114f6e6cb8 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
