----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review148314 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 2918) <https://reviews.apache.org/r/51028/#comment215792> I would suggest you use the `createSlaveInfo(const Resources& resources)` for both here and #2929 src/tests/hierarchical_allocator_tests.cpp (line 3584) <https://reviews.apache.org/r/51028/#comment215794> kill the period at the end src/tests/hierarchical_allocator_tests.cpp (line 3603) <https://reviews.apache.org/r/51028/#comment215793> 1) The `allocationRuns.load()` actually include the number of allocations caused by adding agent, we should remove this number here. 2) kill the period at the end - Guangya Liu On 九月 8, 2016, 10:12 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated 九月 8, 2016, 10:12 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Ensure that expected > allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > b2179215f3a4c2f4018670e8e54f02e06c39c3b1 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
