----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review150760 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp (line 224) <https://reviews.apache.org/r/51027/#comment218828> ``` // If no run is queued we only update `allocationCandidates` ``` I think here should be ``` We only update the `allocationCandidates` if there are pending allocation run. ``` src/master/allocator/mesos/hierarchical.cpp (lines 1292 - 1296) <https://reviews.apache.org/r/51027/#comment218825> Can we highlight that this part is mainly used to add `slaveIds` to the `allocationCandidates` because of some event triggered allocations such as `addSlave`, `updateSlave`, `updateAvailable`? src/master/allocator/mesos/hierarchical.cpp (line 1349) <https://reviews.apache.org/r/51027/#comment218829> s/a small subset of slaves/allocation candidates for this cycle ? - Guangya Liu On 九月 28, 2016, 8:21 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51027/ > ----------------------------------------------------------- > > (Updated 九月 28, 2016, 8:21 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus > Ma, and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Triggered allocations dispatch allocate() only > if there is no pending allocation in the queue. > - Allocation candidates are accumulated and only > cleared when enqueued allocations are processed. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > 3f51f4194c1ba7c1e4f08c3dd623281ca5754d39 > > Diff: https://reviews.apache.org/r/51027/diff/ > > > Testing > ------- > > make check > > note: check without filters depends on https://reviews.apache.org/r/51028 > note: SmallOfferFilter fix pending review -> will list Jira here > > > Thanks, > > Jacob Janco > >
