----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151408 -----------------------------------------------------------
Jacob, two other comments for this: 1) when will you have the patch `SmallOfferFilter` ready for review? 2) I think we may need another benchmark test which only do two operations: a) add multiple agents first 2) add multiple frameworks, this test can make sure we `batched` the `allocate()` request for all frameworks. src/master/allocator/mesos/hierarchical.cpp (line 1298) <https://reviews.apache.org/r/51027/#comment219725> The `addFramework` will call `allocate()` and allocate `all agents resources` but not a `single agnent`, so here we should not mention `addFramework`, but only the following three: 1) addSlave 2) updateSlave 3) updateUnavailability? src/master/allocator/mesos/hierarchical.cpp (line 1300) <https://reviews.apache.org/r/51027/#comment219726> s/slaveIds/`slaveIds` - Guangya Liu On 十月 4, 2016, 9:31 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51027/ > ----------------------------------------------------------- > > (Updated 十月 4, 2016, 9:31 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus > Ma, and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Triggered allocations dispatch allocate() only > if there is no pending allocation in the queue. > - Allocation candidates are accumulated and only > cleared when enqueued allocations are processed. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > c8f9492ee1b69e125a1e841116d22a578a9b524e > > Diff: https://reviews.apache.org/r/51027/diff/ > > > Testing > ------- > > make check > > note: check without filters depends on https://reviews.apache.org/r/51028 > note: SmallOfferFilter fix pending review -> will list Jira here > > > Thanks, > > Jacob Janco > >
