----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51486/#review150825 -----------------------------------------------------------
Patch looks great! Reviews applied: [51736, 51737, 51740, 51767, 51768, 51769, 51486] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 29, 2016, 1:46 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51486/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 1:46 a.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > Added `execute` method. > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp > 85547533b0b13011615b512ec8c71b7545f33324 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 > > Diff: https://reviews.apache.org/r/51486/diff/ > > > Testing > ------- > > make. > > Created a network namespace using `ip route2` and used the following script > to test the execution of the 'delegate plugin': > export CNI_COMMAND="DEL" > export CNI_CONTAINERID="0000000111101110" > export CNI_PATH="$MESOS_INSTALL:/home/vagrant/dev/go/cni/bin" > export CNI_IFNAME="eth0" > export CNI_NETNS="/var/run/netns/$1" > $MESOS_SRC/build/src/.libs/mesos-cni-port-mapper < $2 > unset CNI_COMMAND > unset CNI_CONTAINERID > unset CNI_PATH > unset CNI_IFNAME > unset CNI_NETNS > > Here $1 is the name of the netns created by `ip route2` and $2 is the CNI > configuration of the port-mapper plugin. We used the following config: > { > "name": "mynet", > "type": "port-mapper", > "chain": "MESOS", > "delegate": { > "type" : "bridge", > "bridge": "cni0", > "isGateway": true, > "ipMasq": true, > "ipam": { > "type": "host-local", > "subnet": "192.168.37.0/24", > "routes": [ > { "dst": "0.0.0.0/0" } > ] > } > }, > "args" : { > "org.apache.mesos" : { > "network_info" : { > "port_mappings": { > "host_port" : 8090, > "container_port" : 80 > } > } > } > } > } > > > Thanks, > > Avinash sridharan > >
