-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49833/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335
Repository: mesos
Description
-------
In order for different `Flags` classes to be composable classes should
always use virtual inheritance. stout provides the helper template
`flags::Flags` for this purpose.
Here we use inheritance from `flags::Flags` instantiations for all
derived classes, for consistency even in cases where `Flags` classes
are currently not inherited from, or do not use multiple inheritance.
Diffs
-----
3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b
3rdparty/stout/tests/subcommand_tests.cpp
9213d6b9faec30b5be320ab37ca29c2406c964ac
Diff: https://reviews.apache.org/r/49833/diff/
Testing
-------
Tested as part of the review chain ending in
https://reviews.apache.org/r/52388/ on various Linux configurations in internal
CI.
Thanks,
Benjamin Bannier
