----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49833/#review152757 -----------------------------------------------------------
3rdparty/stout/tests/flags_tests.cpp (line 836) <https://reviews.apache.org/r/49833/#comment221853> Remove extraneous newline. 3rdparty/stout/tests/flags_tests.cpp (lines 843 - 848) <https://reviews.apache.org/r/49833/#comment221850> We need to remove these flags which are from `TestFlags`. - Michael Park On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49833/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 2:58 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3335 > https://issues.apache.org/jira/browse/MESOS-3335 > > > Repository: mesos > > > Description > ------- > > In order for different `Flags` classes to be composable classes should > always use virtual inheritance. > > > Diffs > ----- > > 3rdparty/stout/tests/flags_tests.cpp > 94ba915c40836e476cf6097274a85c55acd4d73b > 3rdparty/stout/tests/subcommand_tests.cpp > 9213d6b9faec30b5be320ab37ca29c2406c964ac > > Diff: https://reviews.apache.org/r/49833/diff/ > > > Testing > ------- > > Tested as part of the review chain ending in > https://reviews.apache.org/r/52388/ on various Linux configurations in > internal CI. > > > Thanks, > > Benjamin Bannier > >
