----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52390/ -----------------------------------------------------------
Review request for mesos. Bugs: MESOS-3335 https://issues.apache.org/jira/browse/MESOS-3335 Repository: mesos Description ------- While right now we can technically `add` variables to `Flags` classes which are not members, the in order to have correct copy semantics for `Flags` only member variables should be used. Here we changed all instances to a full pointer-to-member syntax in the current code. Diffs ----- 3rdparty/stout/include/stout/flags.hpp bc4684d499bad6e409953f608330325c4a13d6a6 3rdparty/stout/include/stout/flags/flags.hpp eab8a001ed19755de58386a55ed4972f58026b29 3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b 3rdparty/stout/tests/subcommand_tests.cpp 9213d6b9faec30b5be320ab37ca29c2406c964ac Diff: https://reviews.apache.org/r/52390/diff/ Testing ------- Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various Linux configurations in internal CI. Thanks, Benjamin Bannier