----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52390/ -----------------------------------------------------------
(Updated Oct. 17, 2016, 6:13 p.m.) Review request for mesos and Michael Park. Changes ------- Rebased. Bugs: MESOS-3335 https://issues.apache.org/jira/browse/MESOS-3335 Repository: mesos Description ------- While right now we can technically `add` variables to `Flags` classes which are not members, the in order to have correct copy semantics for `Flags` only member variables should be used. Here we changed all instances to a full pointer-to-member syntax in the current code. Diffs (updated) ----- 3rdparty/stout/README.md 693e3a3e76300f7fa6c6f6518497edf44cc9f6a2 3rdparty/stout/include/stout/flags.hpp b23b6f68b7da93f1c4fa4d4bddc350a615716041 3rdparty/stout/include/stout/flags/flags.hpp e00aedfe1a1fbb5b8ad4786c6a3ca6db5d5faff0 3rdparty/stout/tests/flags_tests.cpp b2de02dbd920601367f5e42d8a39a96a26551425 3rdparty/stout/tests/subcommand_tests.cpp 9cdb1adc0047f2c7baf1089ddc5afa2052b26f57 Diff: https://reviews.apache.org/r/52390/diff/ Testing ------- Tested as part of the review chain ending in https://reviews.apache.org/r/52388/ on various Linux configurations in internal CI. Thanks, Benjamin Bannier