> On Sept. 28, 2016, 6:03 p.m., Joseph Wu wrote: > > This commit should be good-to-go (no further changes needed). I'll commit > > it with the rest of the chain, when the whole chain is ready.
Great. Will fix the rest of the comments later today. Thanks. - Sivaram ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/#review150744 ----------------------------------------------------------- On Sept. 27, 2016, 7:59 p.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52308/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2016, 7:59 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Add variable user to handle switchUser passed from executor. > > Note: The previous rbr to this file commit has been discarded - > https://reviews.apache.org/r/52095/ > > > Diffs > ----- > > src/slave/container_loggers/logrotate.hpp > f906a167f8897385af5f54e1e77ddddcb790121a > > Diff: https://reviews.apache.org/r/52308/diff/ > > > Testing > ------- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
