> On Sept. 29, 2016, 6:35 p.m., Benjamin Bannier wrote: > > Why does this need to be an extra commit? It appears it should just be > > folded into https://reviews.apache.org/r/51605/ which adds this target for > > the automake setup. > > Alexander Rukletsov wrote: > Because it's in libprocess.
Of course, sorry for not looking at the original file more carefully. This does follow the existing pattern, but I am not sure what this pattern accomplishes, e.g., why do these mesos-specific target names need to be defined under libprocess, while all their sources and users are in a directory above? This not only is inconsistent with what we do in the automake world (OK, not not a perfect setup either), but also appears to be contrary to our approach of self-contained 3rdparty components. Could you please file a tech debt cleanup ticket to fix this? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51606/#review150862 ----------------------------------------------------------- On Sept. 2, 2016, 6:42 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51606/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 6:42 p.m.) > > > Review request for mesos, Gastón Kleiman and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > f7cba60c9ef7c7ed27819dcf4939c0c51f80d49e > > Diff: https://reviews.apache.org/r/51606/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/51607/ > > > Thanks, > > Alexander Rukletsov > >
