----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review151266 -----------------------------------------------------------
3rdparty/cmake/Mesos3rdpartyConfigure.cmake (line 50) <https://reviews.apache.org/r/49862/#comment219604> This doesn't appear to be used. And this change may cause the build to use an installed leveldb, versus the repackaged one. I'd recommend separating out the leveldb change (or removing the change) as it is logically separate from the `POSITION_INDEPENDENT_CODE`/`MESOS_DEFAULT_LIBRARY_LINKAGE` change. - Joseph Wu On Sept. 7, 2016, 11:33 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49862/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2016, 11:33 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added fles MESOS_DEFAULT_LIBRARY_LINKAGE which is set to STATIC on > WIN32 and SHARED on OSX or Unix. This allows all libraries built > static or shared. Also minor changes made to eliminate leveldb > dependency when build slave or master. Also by setting the flag > CMAKE_POSITION_INDEPENDENT_CODE to true cmake auto sets the > flag -fPIC. > > > Diffs > ----- > > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > eeb27860f6f95d297ccfe273ed76de5355b50ff8 > 3rdparty/http-parser/CMakeLists.txt.template > 9a671973b754095e1de917f135a7deb978fb6eb6 > cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 > src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 > src/master/cmake/MasterConfigure.cmake > 6bbd7e87273976f40527d719cc9450ff9a1d2ac7 > src/slave/cmake/SlaveConfigure.cmake > b339239761a5de321d65b92376dae69c339bee5c > src/slave/qos_controllers/CMakeLists.txt > 87c92af21c012655c201c01cd4ba5ff912555119 > src/slave/resource_estimators/CMakeLists.txt > 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 > > Diff: https://reviews.apache.org/r/49862/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
